gsk: Document gsk_renderer_realize()
authorNiels De Graef <nielsdegraef@gmail.com>
Tue, 11 Jan 2022 09:04:16 +0000 (10:04 +0100)
committerNiels De Graef <nielsdegraef@gmail.com>
Tue, 11 Jan 2022 12:09:53 +0000 (13:09 +0100)
Document the return value and more importantly, specify that a call to
`gsk_renderer_realize()` needs to be matched with a call
`gsk_renderer_unrealize()`.

Prevents issues like https://gitlab.gnome.org/GNOME/gtk/-/issues/4625

gsk/gskrenderer.c

index ff4ff976ce8e5b1e3c80d497ab398067bf9d8748..b782cfd49305e69fc85ff8a08034bd0afffb3c58 100644 (file)
@@ -289,10 +289,15 @@ gsk_renderer_is_realized (GskRenderer *renderer)
  *
  * Since GTK 4.6, the surface may be `NULL`, which allows using
  * renderers without having to create a surface.
+ *
+ * Note that it is mandatory to call [method@Gsk.Renderer.unrealize] before
+ * destroying the renderer.
+ *
+ * Returns: Whether the renderer was successfully realized
  */
 gboolean
 gsk_renderer_realize (GskRenderer  *renderer,
-                      GdkSurface    *surface,
+                      GdkSurface   *surface,
                       GError      **error)
 {
   GskRendererPrivate *priv = gsk_renderer_get_instance_private (renderer);